Skip to content

fix: server functions inclusivity + runtime exports#2127

Open
lxsmnsyc wants to merge 9 commits into
mainfrom
feat-directives-subpath
Open

fix: server functions inclusivity + runtime exports#2127
lxsmnsyc wants to merge 9 commits into
mainfrom
feat-directives-subpath

Conversation

@lxsmnsyc
Copy link
Copy Markdown
Member

@lxsmnsyc lxsmnsyc commented Apr 4, 2026

  • Fix server functions to allow configurable file filters. I neglected to add this on the original PR.
  • Fix runtime to be exported package rather than accessing it directly by file. Resolution-related issues so this is much better and direct to the point

I've also moved and renamed server fn files since the current ones are too confusing

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 4, 2026

⚠️ No Changeset found

Latest commit: 741ea28

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 4, 2026

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit 741ea28
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/6a01cb4b0db0c40008c30e20
😎 Deploy Preview https://deploy-preview-2127--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 4, 2026

Open in StackBlitz

npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/start@2127
npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/vite-plugin-nitro-2@2127

commit: 741ea28

Comment thread packages/start/src/fns/server.ts
@brenelz
Copy link
Copy Markdown
Contributor

brenelz commented May 6, 2026

Whats the status of this pr?

@lxsmnsyc
Copy link
Copy Markdown
Member Author

lxsmnsyc commented May 6, 2026

@brenelz not much, except maybe there's a recent push on main that needs to be synced. I'll probably take a look later this week

@lxsmnsyc lxsmnsyc force-pushed the feat-directives-subpath branch from 8e77822 to 80ce7e1 Compare May 6, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants